refactor: switch to rapids-artifact-name for consistent artifact naming#1411
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
84e19ad to
6ed0864
Compare
|
/ok to test |
|
/ok to test |
3cfa387 to
7e73e22
Compare
|
/ok to test |
| runs-on: linux-amd64-gpu-l4-latest-1 | ||
| strategy: | ||
| matrix: | ||
| ctk: ["12.9.0"] |
There was a problem hiding this comment.
bumped the ctk version here to pull in a newer container that has updated gha-tools (for rapids-artifact-name)
| date: ${{ inputs.date }} | ||
| package-name: cuopt | ||
| package-type: python | ||
| publish-wheel-search-key: cuopt_wheel_python_cuopt_ |
There was a problem hiding this comment.
There's an annoying chance of naming collisions here, where cuopt_server and cuopt have the same prefix, namely: cuopt_wheel_python_cuopt -- leave a trailing underscore here to ensure it's a cuopt wheel.
For the others, we use hyphens for the artifact names so they don't collide, e.g.
cuopt_wheel_python_cuopt_ doesn't match cuopt_wheel_python_cuopt-server or cuopt_wheel_python_cuopt-sh-client
|
/ok to test |
5e60576 to
9367d74
Compare
|
/ok to test |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (16)
📝 WalkthroughWalkthroughThis PR migrates cuopt's CI/CD scripts from using hardcoded and generic artifact identifiers to dynamically constructing artifact names via the ChangesArtifact Naming and Download Migration
🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/merge |
This PR swaps in
rapids-artifact-nameforrapids-package-nameeverywhere, and also removes any legacy named artifacts. All artifacts now follow the same naming convention (and that convention can be updated/expanded from a central location). Part of rapidsai/build-planning#270